update sepolia deployments #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
approved these changes
Nov 15, 2024
| @@ -0,0 +1,251 @@ | |||
| { | |||
There was a problem hiding this comment.
looks like we haven't committed this file before. not opposed to keeping just want to confirm if intentional
There was a problem hiding this comment.
It's created on every deployment - we have existing ones but should probably just remove all of them tbh
There was a problem hiding this comment.
Looking into this more - we probably want to keep these as it provides the compiler inputs required to regenerate a given deployment. Likewise, we should also keep the .openzeppelin directory manifests.
That being said, we could potentially remove the /typechain-types subdirectory as that's deterministic to a given deployment and package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.