[ENG-286] Use caddy instead of nginx #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheran-senthil
changed the title
dmanjunath
approved these changes
Jan 10, 2025
| @@ -237,48 +201,24 @@ check_ports_and_ip() { | |||
| log_success "Port $port is available" | |||
| fi | |||
| done | |||
|
|
|||
| # Check if ports are accessible from outside | |||
There was a problem hiding this comment.
i forgot why we added this. what's this for?
There was a problem hiding this comment.
This was a test we had to see if ports are actually open, don't think this is necessary. For example when someone is setting up a node, to verify that port 80 or port 443 is open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.