Support static topology #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also renames NodeRegistryImpl to DynamicNodeRegistry. The new static version isn't being used just yet.
This allows StaticNodeRegistry to be used by setting the CONTENT_NODES environment variable as opposed to BOOTSTRAP_NODES, which will still use DynamicNodeRegistry if set.
the-masthead
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
StaticNodeRegistrywhich is an alternative content node registry implementation to the existing and now-renamedDynamicNodeRegistry. The static version is simply configured with a list of content nodes at init time, whereas the dynamic version queries topology nodes for this information.The service worker still has support for both models. Which one gets used is based on the presence of certain environment variables.