Add release steps into readme file #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
reviewed
Oct 22, 2024
| @@ -47,10 +47,38 @@ The main entry point is [src/service-worker/main.ts](src/service-worker/main.ts) | |||
| └── worker - vendored angular code | |||
| ├── COMMIT - stores the commit that service worker was vendored from | |||
| ├── README.md - how to check the diff between upstream angular service worker and vendored service-worker/src/ files | |||
| ``` | |||
There was a problem hiding this comment.
if you delete this the "How to Release the Service Worker" looks like it's inside a code section
There was a problem hiding this comment.
are you using a README preview tool to see what this looks like locally? if not, there's some good ones i can recommend
There was a problem hiding this comment.
yep, I have an extension
jlmonroy13
force-pushed
the
add-release-steps
branch
from
d7c2eda to
c147321
Compare
dmanjunath
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.