Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup + improvements for easyconfigs test suite #13257

Merged
merged 11 commits into from
Jun 28, 2021

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Jun 25, 2021

Major improvements to the test suite

  • Remove a forgotten debug print
  • Checkout full history on CI to avoid failure to get merge base
  • Remove workaround to cleanup test TMPDIR in favor of class teardown method
  • Process ECs on demand (preparation for next change, but also means for non-prs the ecs-in-pr-changed test is a no-op instead of parsing all ECs and never using them)
  • Refactor the ECs-changed-in-PR test to run the subtests as separate test cases so failures in one of them don't abort the others
  • Ignore cmdline args passed to the test suite, those are handled by unittest and should not be handled by easybuild. This allows to run subsets of tests like: python test/easyconfigs/easyconfigs.py -v -k test_pr to run all PR tests only
  • Remove unused setting of EASYBUILD_DEPRECATED which, if in effect, would cause many failures due to deprecated ECs (using old versions) or even using LMod 6 (on CI) is already deprecated
  • Honor setting of EASYBUILD_TMP_LOGDIR
  • Allow filtering over all tests via: python test/easyconfigs/suite.py -k foo which includes the EC parsing tests. This removes the custom output of "ERROR: Not all tests were successful." but still has the output from unittest

@Flamefire Flamefire force-pushed the improve_testsuite branch from 7301538 to 7028e0a Compare June 25, 2021 11:56
@Flamefire Flamefire force-pushed the improve_testsuite branch from 7028e0a to 1e1ea03 Compare June 25, 2021 12:41
@Flamefire Flamefire force-pushed the improve_testsuite branch from 21595a6 to 17379db Compare June 25, 2021 14:50
@easybuilders easybuilders deleted a comment from boegelbot Jun 25, 2021
@easybuilders easybuilders deleted a comment from boegelbot Jun 25, 2021
@boegel boegel changed the title Improve testsuite code cleanup + improvements for easyconfigs test suite Jun 28, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants