Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the testsuite print error and still return a non-zero exitcode #13770

Merged
merged 2 commits into from
Aug 19, 2021
Merged

make the testsuite print error and still return a non-zero exitcode #13770

merged 2 commits into from
Aug 19, 2021

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Aug 18, 2021 •
edited
Loading

see #13767 (comment)

If the tests fail then the || echo "ERROR: Not all tests were successful" means that the non-zero exit code is taken since the echo succeeds.

@branfosj branfosj mentioned this pull request Aug 18, 2021
Merged
@branfosj branfosj changed the title revert #13745 make the testsuite print error and still return a non-zero exitcode Aug 18, 2021
@branfosj branfosj requested a review from boegel August 18, 2021 18:43
@branfosj branfosj added this to the next release (4.4.2?) milestone Aug 18, 2021
Micket
Micket approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.. how can this not have been caught earlier?

@boegel
Copy link
Member

boegel commented Aug 19, 2021

lgtm.. how can this not have been caught earlier?

@Micket This was introduced very recently, see #13745

boegel
boegel approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 807ce6a into easybuilders:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Micket Micket Micket approved these changes

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@branfosj @boegel @Micket