Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[gfbf/2023a] PyEXR v0.3.10 #19983

Merged

Conversation

jfgrimm
Copy link
Member

@jfgrimm jfgrimm commented Feb 27, 2024

(created using eb --new-pr)

@jfgrimm jfgrimm added the new label Feb 27, 2024
@migueldiascosta
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=19983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19983 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12980

Test results coming soon (I hope)...

- notification for comment with ID 1968054925 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2d612cf3ea8c5d5dea6a02eeade2b994 for a full test report.

@migueldiascosta
Copy link
Member

if this is required specifically for toolchain version 2023a, with OpenEXR 3.1.7, lgtm

it looks like the python bindings are included in OpenEXR itself from version 3.2.0, so an easyconfig for PyEXR using that toolchain version could probably be simplified (but I suppose that would also require adding e.g. -DOPENEXR_BUILD_PYTHON=ON to the existing OpenEXR-3.2.0-GCCcore-13.2.0.eb easyconfig)

@jfgrimm
Copy link
Member Author

jfgrimm commented Feb 28, 2024

@migueldiascosta I actually tried doing exactly that (adding -DOPENEXR_BUILD_PYTHON=ON to the GCCcore/13.2.0 based ec) and... didn't end up with any python bindings in the OpenEXR install dir.

@migueldiascosta
Copy link
Member

@jfgrimm looks like stills are still in flux (AcademySoftwareFoundation/openexr#1629)

what about leaving a comment for whoever picks up on PyEXR later to look into using the python bindings from OpenEXR (3.2.3?) itself?

@verdurin
Copy link
Member

@jfgrimm thoughts on Miguel's suggestion?

@jfgrimm
Copy link
Member Author

jfgrimm commented Mar 15, 2024

@migueldiascosta @verdurin good idea, done

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/c227bc8d8c6b5f32d4febc2955cd6720 for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=19983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19983 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13347

Test results coming soon (I hope)...

- notification for comment with ID 2071933478 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b5608a5c999000ea2208ec05ff464d2f for a full test report.

@verdurin
Copy link
Member

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19983 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4023

Test results coming soon (I hope)...

- notification for comment with ID 2071947383 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/478fe1079f0403eba1b29867dc0d5959 for a full test report.

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the release after 4.9.1 milestone Apr 23, 2024
@verdurin
Copy link
Member

Going in, thanks @jfgrimm!

@verdurin verdurin merged commit db78bd0 into easybuilders:develop Apr 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants