try to reduce the size of the library #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjnixon
force-pushed
the
smaller
branch
7 times, most recently
from
52e749c to
2d36ce3
Compare
- make Combine corecursive with HasParameters so that the tail stays encoded as a list of parameter classes, rather than the full inheritance structure - avoid using CombineRaw by adding more combination classes that inherit from two bases - avoid virtual base in variant parameter - add tests for variant parameters - move more of the details out of the main header - move tag types out of template parameters - turn flags into types to cut down on symbols
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
- Coverage 89.45% 89.42% -0.04%
==========================================
Files 125 125
Lines 5692 5703 +11
==========================================
+ Hits 5092 5100 +8
- Misses 600 603 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto base changes are not done (needs tidying and the comments need updating), but here's the impact on the size (before and after stripping) of libadm.a in a MinSizeRel build: