Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioObjects without using the incomplete hard-coded Lookup-Tables #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

merktj
Copy link

@merktj merktj commented Apr 14, 2021

Because the libadm lookup-tables are incomplete, this pull request extends object_creation.hpp/cpp by a function to add AudioObjects directly using AudioTrack/AudioPackFormatIds.
This is needed for the ear-production-suite direct speakers support of additional layouts beside from the ones specified in BS.2051.

…ctly add objects via AudioPack/AudioTrackFormatIds without hardcoded lookup-table access.
@codecov-commenter
Copy link

Codecov Report

Merging #68 (9aac8cc) into master (146670a) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
- Coverage   89.51%   89.08%   -0.44%     
==========================================
  Files         115      115              
  Lines        5534     5561      +27     
==========================================
  Hits         4954     4954              
- Misses        580      607      +27     
Impacted Files Coverage Δ
include/adm/utilities/object_creation.hpp 100.00% <ø> (ø)
src/utilities/object_creation.cpp 63.51% <0.00%> (-36.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146670a...9aac8cc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants