Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): remove tertiary button background and update components using it - FRONT-4295 #3291

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Mar 18, 2024

  • remove white background on tertiary button (EC and EU)
  • site header: use default tertiary button display (login, language switcher, search and menu)
  • carousel: remove button previous/next (so no more tertiary button here)
  • gallery: use tertiary button, but keep a white background by default. Also add an extra border on focus

Copy link

github-actions bot commented Mar 18, 2024

@github-actions github-actions bot temporarily deployed to pull request March 18, 2024 12:53 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 19, 2024 13:00 Inactive
@emeryro emeryro changed the title feat(button): remove tertiary button background - FRONT-4295 feat(button): remove tertiary button background and update components using it - FRONT-4295 Mar 20, 2024
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 07:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request March 20, 2024 12:05 Inactive
Copy link
Collaborator

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me, but the hamburger in EC is now barely visible..

@planctus planctus merged commit 19784c1 into v4-dev Mar 21, 2024
7 checks passed
@planctus planctus deleted the FRONT-4295-tertiary-button branch March 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants