feat(file-upload): add aria-live - FRONT-4318 #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planctus
reviewed
Mar 25, 2024
| @@ -128,6 +128,7 @@ export class FileUpload { | |||
|
|
|||
| // Update file list | |||
| this.fileUploadList.innerHTML = fileList; | |||
| this.fileUploadList.setAttribute('aria-live', 'polite'); | |||
There was a problem hiding this comment.
just to be sure we are really doing somethign beneficial for the accessibility, i went reading the docs and i see that:
The aria-live attribute is set on an empty element. When an update to the page occurs, the empty element with that aria-live attribute should be updated with a brief announcement informing the user an update has been made.
So i wonder, shouldn't this be set initially, before we populate the list, so that when the list is populated the new content will be announced..? If the request was explicitely expecting this when the content it's added, forget about this
There was a problem hiding this comment.
I don't fully know how the aria-live attribute works.. I'll ask Regine
planctus
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-liveto the file list