feat(layout): update max width - FRONT-4381 #3351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emeryro
commented
Apr 17, 2024
emeryro
commented
- update global max width to 80ch
planctus
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Question: we noticed that in some cases we are setting the max-width on a container with multiple elements, like a title, a description, as a "group" but this has consequences, the result is not the same as it would if the max-width would be set on each element individually. Shoouldn't we take care of this in the context of this pr..?
|
This is a quick first step here. DG COMM is investigating for each component what should use the max width or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.