-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(media container): disable Youtube shortcuts - FRONT-4363 #3353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmhh..but, this works with youtube videos only, i don't really think that adding this in the demo would be understood in its relevance concerning the accessibility.
It feels that we should do this via the js more than expecting users to append this string to the url and if that exists, it would also be nice to be able to pass the right "option" to the right player.
At the same time the first link that i followed, leading to the a discussion in the drupal community, is this: https://www.drupal.org/project/video_embed_field/issues/3228051 the decision was not to append the option to disable the keyboard shortcuts..
I'll double check this |
As it seems, this is still require to disable these shortcuts (that's a shame...) It has been done for Youtube, as it was the initial request. If needed for other players, that would require more investigation |
note: this is only for Youtube videos currently, as each player may have its own way of handling shortcuts, and it may or may not be an issue