Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(media container): disable Youtube shortcuts - FRONT-4363 #3353

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Apr 18, 2024

  • disable keyboard shortcuts for Youtube player (it is interfering with the screen reader shortcuts)
    note: this is only for Youtube videos currently, as each player may have its own way of handling shortcuts, and it may or may not be an issue

Copy link

github-actions bot commented Apr 18, 2024

@github-actions github-actions bot temporarily deployed to pull request April 18, 2024 07:43 Inactive
@emeryro emeryro changed the title feat(media-container): disable shortcut feat(media-container): disable shortcut - FRONT-4363 Apr 23, 2024
@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 05:53 Inactive
@emeryro emeryro marked this pull request as ready for review April 23, 2024 05:54
@github-actions github-actions bot temporarily deployed to pull request April 23, 2024 06:03 Inactive
Copy link
Collaborator

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmhh..but, this works with youtube videos only, i don't really think that adding this in the demo would be understood in its relevance concerning the accessibility.
It feels that we should do this via the js more than expecting users to append this string to the url and if that exists, it would also be nice to be able to pass the right "option" to the right player.
At the same time the first link that i followed, leading to the a discussion in the drupal community, is this: https://www.drupal.org/project/video_embed_field/issues/3228051 the decision was not to append the option to disable the keyboard shortcuts..

@emeryro
Copy link
Contributor Author

emeryro commented Apr 24, 2024

I'll double check this

@github-actions github-actions bot temporarily deployed to pull request June 26, 2024 06:00 Inactive
@emeryro emeryro changed the title feat(media-container): disable shortcut - FRONT-4363 feat(media-container): disable Youtube shortcuts - FRONT-4363 Jul 11, 2024
@emeryro emeryro changed the title feat(media-container): disable Youtube shortcuts - FRONT-4363 feat(media container): disable Youtube shortcuts - FRONT-4363 Jul 11, 2024
@github-actions github-actions bot temporarily deployed to pull request July 11, 2024 12:47 Inactive
@emeryro
Copy link
Contributor Author

emeryro commented Jul 11, 2024

As it seems, this is still require to disable these shortcuts (that's a shame...)

It has been done for Youtube, as it was the initial request. If needed for other players, that would require more investigation

@planctus planctus merged commit 0314471 into v4-dev Jul 12, 2024
7 checks passed
@planctus planctus deleted the FRONT-4363-acc-youtube-shortcut branch July 12, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants