Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(banner): keep aspect ration between mobile and desktop - FRONT-4412 #3376

Merged
merged 2 commits into from
May 21, 2024
Merged

feat(banner): keep aspect ration between mobile and desktop - FRONT-4412 #3376

merged 2 commits into from
May 21, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented May 2, 2024

  • remove the fixed aspect ratio on mobile and use the one corresponding to the banner size

@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024 •
edited
Loading

🚀 Deployed on https://ecl-preview-3376--europa-component-library.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 2, 2024 13:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 6, 2024 14:03 Inactive
@planctus planctus self-requested a review May 7, 2024 11:04
@emeryro emeryro merged commit 89f8eda into v4-dev May 21, 2024
7 checks passed
@emeryro emeryro deleted the FRONT-4412-banner-mobile branch May 21, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planctus planctus planctus approved these changes

Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emeryro @planctus