feat(lists): Styles - FRONT-4417 #3389
Conversation
…ent-library into FRONT-4417-Lists
| @@ -40,6 +40,10 @@ $list: null !default; | |||
| &:last-of-type { | |||
| margin-bottom: var(--s-xs); | |||
| } | |||
|
|
|||
| .ecl-link { | |||
| text-decoration: none; | |||
There was a problem hiding this comment.
shouldn't we use standalone links here instead of forcing the display? There may be links inside paragraphs that would still need to be underlined
There was a problem hiding this comment.
ehm..we do not include the link component here, we expect markup to be passed to the template, instead, and this would mean that the users would have to add the ecl-link--standalone every time they want to have a link.
I do not understand the reason for this change, but i'd say that if the expected look and feel with links is without the underline better doing this than introducing a breaking change.
…y into FRONT-4417-Lists
| term-margin-top: var(--s-m), | ||
| term-font: var(--f-m), | ||
| term-margin-bottom: var(--s-2xs), | ||
| term-margin-top: var(--s-l), | ||
| definition-font: var(--f-p-m), |
There was a problem hiding this comment.
| definition-font: var(--f-p-m), | |
| definition-font: var(--f-m), |
font prolonged is deprecated on EU
|
On EU, the bullets are going a little outside the container This is also the case on EC when there are more than 9 items I don't think that this is real issue, but we may receive remarks about that |
|
true, although i haven't investigated the reason why this difference in EC and EU, is it just the marker used, i wonder..? Anyway, it seemed relevant to align the "initial" content of the lists with the content in the grid, so i added a minimal padding left in EU. |
No description provided.