Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(range): add bubble for value - FRONT-4436 #3420

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Jun 4, 2024

  • display current value in a bubble

Note: mouse hover is handled with javascript, to avoid an issue where the bubble is also displayed when hovering the form label
image

Copy link

github-actions bot commented Jun 4, 2024

@github-actions github-actions bot temporarily deployed to pull request June 4, 2024 12:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 11, 2024 11:04 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 12:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 13, 2024 13:19 Inactive
@planctus
Copy link
Collaborator

But why do also show the old counter..? Questionable per se the need for this new display, guess that we are copy pasting design ideas from material, basically, but like this it really feels is redundant, no..?

@github-actions github-actions bot temporarily deployed to pull request June 14, 2024 11:34 Inactive
@emeryro
Copy link
Contributor Author

emeryro commented Jun 17, 2024

That's not really redondant: the bubble is only displayed when the range is hover or focus, while the "static" value display is always there

@planctus planctus removed the Question label Jun 17, 2024
@planctus
Copy link
Collaborator

if you say so..that is the definition of a duplication, i'd say, the info is already present and then we show it a second time, Anyway, fine, surely not the biggest concern i have regarding all that we are doing.

@planctus planctus merged commit c25751c into v4-dev Jun 17, 2024
7 checks passed
@planctus planctus deleted the FRONT-4436-range-bubble branch June 17, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants