feat(select): Making the select all and search field optional in the multiselect - FRONT-4462 #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
approved these changes
Jun 18, 2024
planctus
changed the title
emeryro
requested changes
Jul 1, 2024
…/europa-component-library into FRONT-4462-Select-all-optional
|
It seems i forgot to push the last commit, did it now, most likely it's where i applied the changes to the arrow down navigation.. |
emeryro
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr three tickets are tackled:
For what concerns the usage of arrow down, the attempt here is to mitigate the effects of this pr: #3322 where the navigation with arrowDown was stopped on the last checkbox to prevent the closure of the dropdown.
Now, there is no need to prevent the user from accessing the toolbar using arrowDown, the closure of the dropdown was due to a wrong operation performed by us, so now what happens is that if the toolbar is in place arrowDown will continue to work after the last checkbox, if it's not shown, instead, to take into account the Regine's recommendation, arrowDown stops working on the last option not restarting the loop, although also this looks unreasonable to me, i'm not surprised we received this "request" considering the concerns i expressed in the aforementioned pr.