-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): EU styles - FRONT-4451 #3449
Conversation
@@ -36,11 +36,16 @@ $button-width: 44px; | |||
margin: 0; | |||
padding-inline-start: 0; | |||
transition-duration: 0.4s; | |||
|
|||
.ecl-tabs[data-ecl-auto-initialized] & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this rule will be applied, as there is no .ecl-tabs children of .ecl-tabs
Also targeting auto-initialized data would exclude user doing the initialization on their side. If this is to delay the css after javascript init, better add a css class from the js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm confused, this selector is nested in the .ecl-tabs-list selector, so this results in:
.ecl-tabs[data-ecl-auto-initialized] .ecl-tabs-list and it is correctly applied.
the data-ecl-auto-initialized attribute might sound confusing, but we do this in all of our classes in the init() method, so it's not only limited to implmentations using the autoInit.
this.element.setAttribute('data-ecl-auto-initialized', 'true');
No description provided.