feat(mega-menu): Making the hamburger a button with javascript - FRONT-4519 #3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeryro
requested changes
Jul 16, 2024
There was a problem hiding this comment.
That's one way to handle these recurring request, indeed...
Not really of fan of these DOM modification, but if it could close this topic for once, fine for me.
One thing missing though: we no longer have the button/link label changing based on the context (previously it switched between "Menu" and "Close")
…pa/europa-component-library into FRONT-4519-Hamburger-as-a-button
|
I would hardly define myself as a fan of this, this was a way to fulfill the request while still maintaining the no-js fallback approach. I fixed the label switch |
planctus
changed the title
emeryro
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…