feat(video): Adding template for video, using it in different components - FRONT-4497 #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pa-component-library into FRONT-4497-Video-template
emeryro
requested changes
Aug 26, 2024
| @@ -3138,7 +3138,7 @@ exports[`Gallery Default renders correctly with old data 1`] = ` | |||
| </div> | |||
| <video | |||
| aria-label="EU law - Video" | |||
| class="ecl-gallery__image" | |||
| class="ecl-video ecl-gallery__image" | |||
| poster="https://inno-ecl.s3.amazonaws.com/media/examples/example-image5.jpg" | |||
There was a problem hiding this comment.
For some reason we lost the change in the gallery data, using another html video.
It could be good to bring it back while we are changing the gallery and also use it in the video component data)
https://github.com/ec-europa/europa-component-library/pull/3554/files#diff-330b93090781d35d9db384dca62ddc8ab9726a69caccb37617070e162ff45beaR92
|
|
||
| {# | ||
| Parameters: | ||
| - "image" (string) (default: '') |
There was a problem hiding this comment.
should be poster here I guess
| }, | ||
| ... | ||
| ], | ||
| - "video": (associative array) (default: {}) Object of type ECL video | ||
| - "image" (string) (default: ''): Image to be used as the video placeholder |
There was a problem hiding this comment.
the image parameter should be deprecated
…pa-component-library into FRONT-4497-Video-template
emeryro
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.