-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carousel): Styles update - FRONT-4571 #3583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opa-component-library into FRONT-4571-Carousel-update
…opa-component-library into FRONT-4571-Carousel-update
… rendering - FRONT-4571
…y into FRONT-4571-Carousel-update
emeryro
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I didn't know that scroll-snap-align
property...
planctus
added a commit
that referenced
this pull request
Sep 6, 2024
* feat(carousel): Using pause-outline icon - FRONT-4571 * feat(carousel): Styles - FRONT-4571 * feat(carousel): Increasing margin in controls for EC - FRONT-4571 * feat(carousel): Alignment of the play button in large viewports - FRONT-4571 * feat(carousel): Reintroducing shadows, removing border bottom - FRONT-4571 * feat(carousel): Padding in the controls area - FRONT-4571 * feat(carousel): Single slide display, hiding element initially - FRONT-4571 * feat(carousel): Removing debug - FRONT-4571 * feat(carousel): fixing full width use case - FRONT-4571 * feat(carousel): Only hide on init - FRONT-4571 * feat(carousel): Adding text in the demo for grid content - FRONT-4571 * feat(carousel): Consistent calculations removing the scrollbar before rendering - FRONT-4571 * feat(carousel): Css only layout, js is only sliding now - FRONT-4571 --------- Co-authored-by: Romain Emery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.