Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): improve border display - FRONT-4584 #3587

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Aug 27, 2024

This is not a perfect solution, as there may be a darker border is the multi header element is at the end, but that's already better than the current situation
image
image

Copy link

github-actions bot commented Aug 27, 2024

@github-actions github-actions bot temporarily deployed to pull request August 27, 2024 08:13 Inactive
@planctus
Copy link
Collaborator

mmhh..i don't know, on linux with firefox i do not have the "missing" border, it's really tricky with all those overrides, but i don't seem to be able to find a simpler approach, just that it's pretty easy to see the limits of this approach:
image
and although the border color would not be correct with this markup in the current situation it would still be better than what we would get now.

@github-actions github-actions bot temporarily deployed to pull request September 2, 2024 11:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 2, 2024 12:02 Inactive
@emeryro
Copy link
Contributor Author

emeryro commented Sep 2, 2024

I pushed an update. On my side it seems to fix the issue on Chrome and Firefox

@planctus planctus merged commit b4feacd into v4-dev Sep 3, 2024
7 checks passed
@planctus planctus deleted the FRONT-4584-table-border branch September 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants