Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inpage): Using the right element to determine the top position in mobile - FRONT-4620 #3629

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat(inpage): Using the right element to determine the top position in mobile - FRONT-4620 #3629

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ee0a9
feat(inpage): Using the right element to determine the top position i…
planctus Sep 16, 2024
2cde6d3
feat(inpage): Aligning EC and EU - FRONT-4620
planctus Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/implementations/vanilla/components/inpage-navigation/inpage-navigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,13 @@ export class InpageNavigation {
// Mobile
setTimeout(() => {
if (viewportWidth < 996) {
topPosition = this.toggleElement.getBoundingClientRect().bottom + 16;
const toggleWrapper = this.toggleElement.parentElement;
if (toggleWrapper) {
// EC has currently a negative margin set on the wrapper.
topPosition =
toggleWrapper.getBoundingClientRect().bottom +
parseFloat(window.getComputedStyle(toggleWrapper).marginBottom);
}
} else if (listTitle) {
// If we have a title in desktop
topPosition = listTitle.getBoundingClientRect().bottom;
Expand Down
Loading