Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): fix rtl display on mobile - FRONT-4624 #3637

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

emeryro
Copy link
Contributor

@emeryro emeryro commented Sep 23, 2024

Fix margin on mobile rtl

Copy link

github-actions bot commented Sep 23, 2024

@github-actions github-actions bot temporarily deployed to pull request September 23, 2024 08:02 Inactive
Copy link
Collaborator

@planctus planctus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It seems that we are "losing" (it's already the case in production) alignment between the headings and the cells in EU, maybe we can take care of this here.

@emeryro
Copy link
Contributor Author

emeryro commented Sep 24, 2024

The spacing was wrong on EU anyways (compared to figma).
It's fixed

@github-actions github-actions bot temporarily deployed to pull request September 24, 2024 11:33 Inactive
@planctus planctus merged commit 655a024 into v4-dev Sep 24, 2024
7 checks passed
@planctus planctus deleted the FRONT-4624-table-rtl branch September 24, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants