Skip to content

Commit

Permalink
DQA-7736: Remove filterFolders from PHPMD ignore_patterns (#693)
Browse files Browse the repository at this point in the history
  • Loading branch information
Juanpe Buenestado Perez authored Sep 8, 2023
1 parent 0811e2c commit 9b06d10
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
1 change: 0 additions & 1 deletion src/TaskRunner/Commands/TestsCommands.php
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ public function toolkitTestPhpmd(array $options = [
}

if (!empty($options['ignore_patterns'])) {
Toolkit::filterFolders($options['ignore_patterns']);
$execOptions['exclude'] = implode(',', $options['ignore_patterns']);
}
if (!empty($options['triggered_by'])) {
Expand Down
9 changes: 3 additions & 6 deletions tests/fixtures/commands/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,8 @@
1 => 'ansi',
2 => 'phpmd.xml',
))
->options(array (
'exclude' => '',
'suffixes' => 'php,module,inc,theme,install',
))
[Simulator] Running ./vendor/bin/phpmd '' ansi phpmd.xml --exclude --suffixes 'php,module,inc,theme,install'
->options(array ( ... ))
[Simulator] Running ./vendor/bin/phpmd '' ansi phpmd.xml --exclude 'dist/,.cache/,vendor/,web/,node_modules/,config/' --suffixes 'php,module,inc,theme,install'
- command: 'toolkit:test-phpmd'
configuration: []
Expand All @@ -133,7 +130,7 @@
2 => 'phpmd.xml',
))
->options(array ( ... ))
[Simulator] Running ./vendor/bin/phpmd src ansi phpmd.xml --exclude vendor/ --suffixes 'php,module,inc,theme,install'
[Simulator] Running ./vendor/bin/phpmd src ansi phpmd.xml --exclude 'dist/,.cache/,vendor/,web/,node_modules/,config/' --suffixes 'php,module,inc,theme,install'
- command: 'toolkit:check-phpcs-requirements'
configuration: []
Expand Down

0 comments on commit 9b06d10

Please sign in to comment.