DQA-9566: DRUPAL_REVERSE_PROXY not properly set #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhy81
approved these changes
Jun 12, 2024
jonhy81
approved these changes
Jun 12, 2024
mike-michal
reviewed
Jun 12, 2024
| if (intval(getenv('DRUPAL_REVERSE_PROXY_ENABLE')) === 1) { | ||
| \$settings['reverse_proxy'] = (bool) getenv('DRUPAL_REVERSE_PROXY_ENABLE'); | ||
| if (filter_var(getenv('DRUPAL_REVERSE_PROXY_ENABLE'), FILTER_VALIDATE_BOOLEAN)) { | ||
| \$settings['reverse_proxy'] = getenv('DRUPAL_REVERSE_PROXY_ENABLE'); |
There was a problem hiding this comment.
Shouldn't it be like this: $settings['reverse_proxy'] = true; ? Usage of FILTER_VALIDATE_BOOLEAN can handle multiple truthy values like "1", "true", "on" and "yes" and assigns the raw value of getenv('DRUPAL_REVERSE_PROXY_ENABLE') to $settings['reverse_proxy'], which could be a string ("true", "1", etc.).
There was a problem hiding this comment.
Hi @Ozyrys ,
The problem is the different infrastructures, in one side it should be True and another should be 1.
To make this more flexible, I decided to let it just receive the value defined by each project, but using the filter_var() just to ensure that is set and is any kind of positive.
Let me know if it make sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.