feat: validate material list to be empty before deletion #2765
Conversation
| methods: { | ||
| deleteErrorHandler (e) { | ||
| if (e?.response?.status === 422 /* Validation Error */) { | ||
| return this.$tc('components.camp.campMaterialListsItem.deleteError') |
There was a problem hiding this comment.
Why don't we say, what the reason is, instead of just a generic message?
There was a problem hiding this comment.
I assume it's because it currently doesn't work, see #2764 which he opened around the same time as this PR
There was a problem hiding this comment.
The main motivation was, because the backend error comes without translation. So I kind of assume that all 422 errors are due to fact that the list was not empty (there's no other deletion validation at the moment).
Would certainly be cleaner to implement proper translation codes.
| @@ -42,6 +42,11 @@ class MaterialList extends BaseEntity implements BelongsToCampInterface, CopyFro | |||
| /** | |||
| * The items that are part of this list. | |||
| */ | |||
| #[Assert\Count( | |||
| exactly: 0, | |||
| exactMessage: 'It\'s not possible to delete a material list as long as it has items linked to it.', | |||
There was a problem hiding this comment.
Do we already have a concept for api error messaging?
| methods: { | ||
| deleteErrorHandler (e) { | ||
| if (e?.response?.status === 422 /* Validation Error */) { | ||
| return this.$tc('components.camp.campMaterialListsItem.deleteError') |
There was a problem hiding this comment.
I assume it's because it currently doesn't work, see #2764 which he opened around the same time as this PR
| @@ -42,6 +42,11 @@ class MaterialList extends BaseEntity implements BelongsToCampInterface, CopyFro | |||
| /** | |||
| * The items that are part of this list. | |||
| */ | |||
| #[Assert\Count( | |||
| exactly: 0, | |||
| exactMessage: 'It\'s not possible to delete a material list as long as it has items linked to it.', | |||
No description provided.