Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(print): remove pagedjs + prepare for alpha #3036

Merged
merged 18 commits into from
Oct 8, 2022
Merged

chore(print): remove pagedjs + prepare for alpha #3036

merged 18 commits into from
Oct 8, 2022

Conversation

usu
Copy link
Member

@usu usu commented Oct 8, 2022 •
edited
Loading

Based on #3024

  • remove pagedjs from nuxt print
  • implement simple screen preview for nuxt print
  • hide developer previews
  • refine user experience to select a print engine

Before

image

After

image

User view:
image

Developer view (on localhost):
image

@usu usu marked this pull request as ready for review October 8, 2022 13:39
@usu usu added the deploy! Creates a feature branch deployment for this PR label Oct 8, 2022
BacLuc
BacLuc reviewed Oct 8, 2022
View reviewed changes
frontend/src/locales/de.json Outdated Show resolved Hide resolved
frontend/src/locales/en.json Outdated Show resolved Hide resolved
@pmattmann
Copy link
Member

nice

carlobeltrame
carlobeltrame approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still convinced the generic-error-message could be done better. But I can open an issue for that and do it some time in the future.

.helm/ecamp3/templates/print_configmap.yaml Outdated Show resolved Hide resolved
frontend/src/views/camp/Story.vue Show resolved Hide resolved
print/print.env Outdated Show resolved Hide resolved
carlobeltrame
carlobeltrame approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glaube du hast das .stop auf den falschen React Button gemacht

frontend/src/components/print/print-react/DownloadReactPdfButton.vue Outdated Show resolved Hide resolved
frontend/src/components/print/print-react/DownloadReactPdfListItem.vue Outdated Show resolved Hide resolved
@usu usu merged commit 57c1463 into ecamp:devel Oct 8, 2022
This was referenced Oct 8, 2022
Closed
Closed
@usu usu deleted the chore/remove-pagedjs branch November 6, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc left review comments

@pmattmann pmattmann pmattmann approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@usu @pmattmann @BacLuc @carlobeltrame