Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update symfony packages to v7 (major) #4286

Merged
merged 3 commits into from
Jan 2, 2024
Merged

fix(deps): update symfony packages to v7 (major) #4286

merged 3 commits into from
Jan 2, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 20, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
symfony/asset (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/browser-kit (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/console (source) 6.4.1 -> 7.0.1 age adoption passing confidence
symfony/css-selector (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/debug-bundle (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/dotenv (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/expression-language (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/framework-bundle (source) 6.4.1 -> 7.0.1 age adoption passing confidence
symfony/http-client (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/intl (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/mailer (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/phpunit-bridge (source) 6.4.1 -> 7.0.1 age adoption passing confidence
symfony/property-access (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/property-info (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/runtime (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/security-bundle (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/serializer (source) 6.4.1 -> 7.0.1 age adoption passing confidence
symfony/stopwatch (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/translation (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/twig-bundle (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/validator (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/var-dumper (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/web-profiler-bundle (source) 6.4.0 -> 7.0.0 age adoption passing confidence
symfony/yaml (source) 6.4.0 -> 7.0.0 age adoption passing confidence

Release Notes

symfony/asset (symfony/asset)

v7.0.0

Compare Source

symfony/browser-kit (symfony/browser-kit)

v7.0.0

Compare Source

Changelog (symfony/browser-kit@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/console (symfony/console)

v7.0.1

Compare Source

Changelog (symfony/console@v7.0.0...v7.0.1)

  • no significant changes

v7.0.0

Compare Source

Changelog (symfony/console@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/css-selector (symfony/css-selector)

v7.0.0

Compare Source

symfony/debug-bundle (symfony/debug-bundle)

v7.0.0

Compare Source

Changelog (symfony/debug-bundle@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/dotenv (symfony/dotenv)

v7.0.0

Compare Source

Changelog (symfony/dotenv@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/expression-language (symfony/expression-language)

v7.0.0

Compare Source

Changelog (symfony/expression-language@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/framework-bundle (symfony/framework-bundle)

v7.0.1

Compare Source

Changelog (symfony/framework-bundle@v7.0.0...v7.0.1)

v7.0.0

Compare Source

Changelog (symfony/framework-bundle@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/http-client (symfony/http-client)

v7.0.0

Compare Source

Changelog (symfony/http-client@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/intl (symfony/intl)

v7.0.0

Compare Source

Changelog (symfony/intl@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/mailer (symfony/mailer)

v7.0.0

Compare Source

Changelog (symfony/mailer@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/phpunit-bridge (symfony/phpunit-bridge)

v7.0.1

Compare Source

Changelog (symfony/phpunit-bridge@v7.0.0...v7.0.1)

v7.0.0

Compare Source

Changelog (symfony/phpunit-bridge@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/property-access (symfony/property-access)

v7.0.0

Compare Source

Changelog (symfony/property-access@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/property-info (symfony/property-info)

v7.0.0

Compare Source

Changelog (symfony/property-info@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/runtime (symfony/runtime)

v7.0.0

Compare Source

symfony/security-bundle (symfony/security-bundle)

v7.0.0

Compare Source

Changelog (symfony/security-bundle@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/serializer (symfony/serializer)

v7.0.1

Compare Source

Changelog (symfony/serializer@v7.0.0...v7.0.1)

v7.0.0

Compare Source

Changelog (symfony/serializer@v7.0.0-RC2...v7.0.0)

symfony/stopwatch (symfony/stopwatch)

v7.0.0

Compare Source

Changelog (symfony/stopwatch@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/translation (symfony/translation)

v7.0.0

Compare Source

Changelog (symfony/translation@v7.0.0-RC2...v7.0.0)

symfony/twig-bundle (symfony/twig-bundle)

v7.0.0

Compare Source

Changelog (symfony/twig-bundle@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/validator (symfony/validator)

v7.0.0

Compare Source

Changelog (symfony/validator@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/var-dumper (symfony/var-dumper)

v7.0.0

Compare Source

Changelog (symfony/var-dumper@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/web-profiler-bundle (symfony/web-profiler-bundle)

v7.0.0

Compare Source

Changelog (symfony/web-profiler-bundle@v7.0.0-RC2...v7.0.0)

  • no significant changes
symfony/yaml (symfony/yaml)

v7.0.0

Compare Source

Changelog (symfony/yaml@v7.0.0-RC2...v7.0.0)

  • no significant changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovate label Dec 20, 2023
@renovate renovate bot changed the title Update symfony packages to v7 (major) fix(deps): update symfony packages to v7 (major) Dec 22, 2023
@usu
Copy link
Member

usu commented Dec 23, 2023

Needs minimum api-platform 3.2.7, hence blocked by #4129

@usu
Copy link
Member

usu commented Dec 28, 2023

In addition, also blocked by #4015, which in turn is blocked by #4188

@renovate Renovate
Copy link
Contributor Author

renovate bot commented Dec 28, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@usu usu force-pushed the renovate/major-symfony branch 2 times, most recently from d7492bd to 19e9e08 Compare December 31, 2023 10:37
@usu usu force-pushed the renovate/major-symfony branch from 19e9e08 to c2cf6e2 Compare December 31, 2023 10:47
@usu usu enabled auto-merge December 31, 2023 11:00
@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Dec 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2023 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc
Copy link
Contributor

BacLuc commented Dec 31, 2023

No problems, cool.
But where did our deprecations go?
Where they all in transitive packages?

Current run:

Time: 09:14.406, Memory: 1.11 GB

OK, but some tests were skipped!
Tests: 1993, Assertions: 4216, Skipped: 1.

Generating code coverage report in Clover XML format ... done [00:00.690]

Remaining indirect deprecation notices (2)

last run on devel


  6x: Since symfony/framework-bundle 6.4: The "annotations.cached_reader" service is deprecated without replacement.
    3x in EndpointQueryCountTest::getContentNodeEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getCollectionEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getItemEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getPatchEndpoints from App\Tests\Api\SnapshotTests

  6x: Since symfony/framework-bundle 6.4: The "annotations.reader" service is deprecated without replacement.
    3x in EndpointQueryCountTest::getContentNodeEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getCollectionEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getItemEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getPatchEndpoints from App\Tests\Api\SnapshotTests

  6x: Since symfony/framework-bundle 6.4: The "annotations.cache_adapter" service is deprecated without replacement.
    3x in EndpointQueryCountTest::getContentNodeEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getCollectionEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getItemEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getPatchEndpoints from App\Tests\Api\SnapshotTests

  5x: Since symfony/validator 6.4: Method "Symfony\Component\Validator\ValidatorBuilder::setDoctrineAnnotationReader()" is deprecated without replacement.
    2x in EndpointQueryCountTest::getContentNodeEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getCollectionEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getItemEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getPatchEndpoints from App\Tests\Api\SnapshotTests

  5x: Since symfony/serializer 6.4: Passing a "Doctrine\Common\Annotations\PsrCachedReader" instance as argument 1 to "Symfony\Component\Serializer\Mapping\Loader\AttributeLoader::__construct()" is deprecated, pass null or omit the parameter instead.
    2x in EndpointQueryCountTest::getContentNodeEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getCollectionEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getItemEndpoints from App\Tests\Api\SnapshotTests
    1x in ResponseSnapshotTest::getPatchEndpoints from App\Tests\Api\SnapshotTests

BacLuc
BacLuc approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
some inserts/updates while editing a category (but should be covered by integration tests)
oauth
registration, password reset, email change

@usu
Copy link
Member

usu commented Dec 31, 2023

But where did our deprecations go? Where they all in transitive packages?

Yes, I think so. As far as I can tell, the depreciation messages were triggered by the following files:

https://github.com/symfony/framework-bundle/blob/6.4/DependencyInjection/FrameworkExtension.php
https://github.com/symfony/framework-bundle/blob/6.4/Resources/config/annotations.php

@usu usu added this pull request to the merge queue Jan 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2024
@BacLuc BacLuc added this pull request to the merge queue Jan 2, 2024
Merged via the queue into devel with commit baf285f Jan 2, 2024
61 checks passed
@BacLuc BacLuc mentioned this pull request Apr 13, 2024
Closed
@BacLuc BacLuc deleted the renovate/major-symfony branch May 26, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelmeister manuelmeister manuelmeister approved these changes

@BacLuc BacLuc BacLuc approved these changes

@carlobeltrame carlobeltrame Awaiting requested review from carlobeltrame

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR renovate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usu @BacLuc @manuelmeister