This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Build and test RISCV #703
Merged
Build and test RISCV #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Schildt <[email protected]>
erikbosch
reviewed
Nov 6, 2023
| @@ -116,12 +118,12 @@ jobs: | |||
| type=semver,pattern={{major}} | |||
|
|
|||
| # only needed for runners without buildx setup, will be slow | |||
There was a problem hiding this comment.
This line can be removed if we use this alt by default, right?
erikbosch
approved these changes
Nov 6, 2023
|
Looks good to me. I did a very simple smoke test just starting the tll.sh container on amd64. I have not tested the risc part. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds and pushes RISCV containers as well. One step further towards full #666
I extended the integration test, so that all containers are tested (before only the one similar to the runner architecture)
As the riscv builds need to based on glibc for the moment, there was no easy way to adapt the general docker file, so I switched to building with cross and having the docker just "package" the binaries. On the plus side
Once this is in, I'd give the rust-cli the same treatment