Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[453701] Add support for Windows Phone 8 platform #13

Merged
merged 3 commits into from
Dec 16, 2014

Conversation

wgalanciak
Copy link
Contributor

Initial support for Windows Phone 8 platform. It does not contain
Windows Phone 7.X support because this system is no longer supported. It
contains set of basic features to create, launch and export native wp8
applications. I have tried to avoid any 3rd party tools for accessing
Windows registry. In result, it uses reg command instead.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453701
Change-Id: Ic0b6732e85bab0bf8845cbe1643b53a862815bfb
Signed-off-by: wgalanciak [email protected]

Initial support for Windows Phone 8 platform. It does not contain
Windows Phone 7.X support because this system is no longer supported. It
contains set of basic features to create, launch and export native wp8
applications. I have tried to avoid any 3rd party tools for accessing
Windows registry. In result, it uses reg command instead.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453701
Change-Id: Ic0b6732e85bab0bf8845cbe1643b53a862815bfb
Signed-off-by: wgalanciak <[email protected]>
@wgalanciak
Copy link
Contributor Author

I have missed this entry. Fixed.

We do not use any 3rd party library to avoid any licensing issues. Plugins contain only java code (also no JNI). Everything is executed through command line (building, launching in emulator, accessing registry).

Remove reference to dll libraries in MANIFEST.MF.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453701
Change-Id: Ic0b6732e85bab0bf8845cbe1643b53a862815bfb
Signed-off-by: wgalanciak [email protected]
@@ -7,6 +7,10 @@
'android' = {
download_url:'https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=snapshot;h=3.6.3;sf=tgz',
version: '3.6.3'
},
'wp8' = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional that we are adding wp8 downloads to 3.6.3 only? How about earlier ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I had only a chance to verify it with 3.6.3 and 3.6.4 and this is a reason why I have added it only for 3.6.3. If you think that it is necessary for the initial release I can spend some additional time on testing older versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue for the initial release, I was just curious

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in general we had a deadline for it because it was officially released as a part of our product Zend Studio 12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize you had already released your product. Congrats!

@gorkem
Copy link
Contributor

gorkem commented Dec 12, 2014

@wgalanciak I think we are ready to merge this one but I would like to fix the missing quotes before the initial checkin since they cause the run/export functionality not to function at all. Will you be able to do a quick update for them.

Apply suggested minor fixes.

Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=453701
Change-Id: I0000000000000000000000000000000000000000
Signed-off-by: wgalanciak [email protected]
gorkem added a commit that referenced this pull request Dec 16, 2014
[453701] Add support for Windows Phone 8 platform
@gorkem gorkem merged commit f4d0299 into eclipse-archived:master Dec 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants