NotTypePattern: Fix matching problem for negated type patterns

The implementation for boolean matchesArray(UnresolvedType type) was buggy. '!String' should match anything but String, no matter if it is an array or not, e.g. int, void, int[], String[], String[][]. '!String[]' should match anything but String[], no matter if it is an array or not, e.g. int, void, int[], String, String[][]. Fixes #257. Signed-off-by: Alexander Kriegisch <[email protected]>
eclipse-aspectj · Aug 23, 2023 · 29b84c2 · 29b84c2
1 parent 4004d0d
commit 29b84c2
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/NotTypePattern.java b/org.aspectj.matcher/src/main/java/org/aspectj/weaver/patterns/NotTypePattern.java
@@ -70,7 +70,12 @@ protected boolean matchesExactly(ResolvedType type, ResolvedType annotatedType)
 
 	@Override
 	protected boolean matchesArray(UnresolvedType type) {
-		return !negatedPattern.matchesArray(type);
+		// '!String' should match anything but String, no matter if it is an array or not,
+		// e.g. int, void, int[], String[], String[][].
+		//
+		// '!String[]' should match anything but String[], no matter if it is an array or not,
+		// e.g. int, void, int[], String, String[][].
+		return true;
 	}
 
 	@Override