Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge methods should be ignored for pointcut matching #256

Closed
kriegaex opened this issue Aug 21, 2023 · 0 comments · Fixed by #255
Closed

Bridge methods should be ignored for pointcut matching #256

kriegaex opened this issue Aug 21, 2023 · 0 comments · Fixed by #255
Assignees
@kriegaex
Labels
bug Something isn't working
Milestone
1.9.20.1

Comments

@kriegaex
Copy link
Contributor

kriegaex commented Aug 21, 2023 •
edited
Loading

This bug is was originally discovered and discussed as a Spring AOP issue. In order for it to be part of the issue list for the next AspectJ release, this tracker issue was created.

Fixes spring-projects/spring-framework#27761.
@kriegaex kriegaex added the bug Something isn't working label Aug 21, 2023
@kriegaex kriegaex self-assigned this Aug 21, 2023
@kriegaex kriegaex added this to the 1.9.20.1 milestone Aug 21, 2023
@kriegaex kriegaex mentioned this issue Aug 20, 2023
Merged
kriegaex added a commit that referenced this issue Aug 21, 2023
@kriegaex
Fix Spring issue 27761
9850bd8 
Fixes spring-projects/spring-framework#27761.
Fixes #256.

Bridge methods are now ignored in favour of their overriding namesakes
during method matching.

Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex added a commit that referenced this issue Aug 21, 2023
@kriegaex
Fix Spring issue 27761
d2c3570 
Fixes spring-projects/spring-framework#27761.
Fixes #256.

Bridge methods are now ignored in favour of their overriding namesakes
during method matching.

Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex added a commit that referenced this issue Aug 22, 2023
@kriegaex
Improve bridge method test, bootstrapping ASM usage
bbe4970 
Instead of using a pre-generated JAR, the source code generating the
class with reordered methods (bridge method first) is now compiled
directly before usage. This is possible, because in the previous commit
ASM was put on the Ajc classpath for tests.

Relates to #256.

Signed-off-by: Alexander Kriegisch <[email protected]>
kriegaex added a commit that referenced this issue Aug 22, 2023
@kriegaex
Improve bridge method test, bootstrapping ASM usage
2af1b06 
Instead of using a pre-generated JAR, the source code generating the
class with reordered methods (bridge method first) is now compiled
directly before usage. This is possible, because in the previous commit
ASM was put on the Ajc classpath for tests.

Relates to #256.

Signed-off-by: Alexander Kriegisch <[email protected]>
@kriegaex kriegaex mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kriegaex kriegaex

Labels
bug Something isn't working
Projects
None yet
Milestone
1.9.20.1
Development

Successfully merging a pull request may close this issue.

Bridge methods should be ignored for pointcut matching eclipse-aspectj/aspectj
1 participant
@kriegaex