Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support next/previous with keyboard across pages (pagination) in table-output-component #848

Open
bhufmann opened this issue Oct 12, 2022 · 3 comments · May be fixed by #881
Open

Support next/previous with keyboard across pages (pagination) in table-output-component #848

bhufmann opened this issue Oct 12, 2022 · 3 comments · May be fixed by #881
Labels
bug Something isn't working Theia UI frontend

Comments

@bhufmann
Copy link
Collaborator

PR #813 upgrades AgGrid to a later version and it required to use pagination. However, selecting an event across pages using arrow down/up or page down/up is not switching to the next page.
@bhufmann bhufmann added bug Something isn't working Theia UI frontend labels Oct 12, 2022
@hoangphamEclipse
Copy link
Contributor

Picking up this issue.

hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 10, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
d8e6fc5 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
@hoangphamEclipse
Copy link
Contributor

I am working on this issue and I am running into some roadblocks. @Rodrigoplp-work can you help me with these questions since you worked on AgGrid?

  1. When users use the Arrow Up to navigate in the view, when they hit the very first row in the data set and press up again, the focus will move into the header (as seen here). This is the default behavior of the AgGrid. Should we modify this behaviour?

  2. UI/UX wise, when user switch pages, we should focus on the cell that is 1) in the same column as previously selected and 2) on the first and last row when we are going forward and backward a page, respectively. I still cannot get this working. I tried using gridAPI.setFocusedCell() but it failed.

hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 10, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
804e752 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 10, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
d1a11de 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 10, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
fbc2ce0 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 14, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
6a5d47c 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 15, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
3af2206 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse added a commit to hoangphamEclipse/theia-trace-extension that referenced this issue Nov 15, 2022
@hoangphamEclipse
Add Arrow Up/Down and Page Up/Down support for table-output-component
6be76f6 
This commit adds support for using the Arrow Up/Down and Page Up/Down
to navigate across pages for views that implements the
table-output-component. Previously, user can only use these keys to
navigate across a page, but can not move forward or backward a page.

Fixes eclipse-cdt-cloud#848.

Signed-off-by: Hoang Thuan Pham <[email protected]>
@hoangphamEclipse hoangphamEclipse linked a pull request Nov 15, 2022 that will close this issue
Draft
@hoangphamEclipse
Copy link
Contributor

  1. When users use the Arrow Up to navigate in the view, when they hit the very first row in the data set and press up again, the focus will move into the header (as seen here). This is the default behavior of the AgGrid. Should we modify this behaviour?

This issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Theia UI frontend
Projects
None yet
Milestone
No milestone
2 participants
@bhufmann @hoangphamEclipse