Fix invalid path on Windows when opening traces #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
requested changes
Feb 8, 2022
|
|
||
| @injectable() | ||
| export class BackendFileServiceImpl implements BackendFileService { | ||
|
|
||
| async findTraces(path: string, cancellationToken: CancellationToken): Promise<string[]> { | ||
| /* |
There was a problem hiding this comment.
remove trailing whitespaces
hoangphamEclipse
force-pushed
the
windows-path-fix
branch
from
a635e09 to
6aaf92f
Compare
Rodrigoplp-work
previously approved these changes
Feb 8, 2022
bhufmann
requested changes
Feb 9, 2022
There was a problem hiding this comment.
The commit message is not formatted properly has to long lines. The main readme has a section about how to contribute code and format the message.
https://github.com/theia-ide/theia-trace-extension#how-to-contribute-code
Please update the commit message accordingly.
Currently, when opening traces on Windows, Theia returns the file path starting with a /. For example, instead of C:/, Theia returns /C://. The path is an invalid Windows path, and prevent the trace extension from opening traces. This is a known issue that requires a work around. This commit resolves this issue by using FileUri to convert the original file path returned by Theia to a platform specific path. This work around will temporarily allow traces to be opened in Windows environment. Signed-off-by: Hoang Thuan Pham <[email protected]>
hoangphamEclipse
force-pushed
the
windows-path-fix
branch
from
6f0a20b to
096c681
Compare
bhufmann
approved these changes
Feb 9, 2022
Rodrigoplp-work
approved these changes
Feb 9, 2022
|
Fixes #545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, Theia returns an invalid file path when opening traces. The invalid file path begins with a forward slash /. For example, the path C:/ will become /C:/. This prevents the trace extension from opening trace files. This is a known Theia issue. More on the issue can be read here.
This commit resolves temporarily this issue by using FileUri to convert the original file path returned by Theia to a platform specific path. This will allow the trace extension to open traces on Windows.
Signed-off-by: Hoang Thuan Pham <[email protected]>