Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up dependencies #1024

Merged
merged 1 commit into from
Dec 18, 2023
Merged

chore: clean up dependencies #1024

merged 1 commit into from
Dec 18, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Clean up some unnecessary dependencies.

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@che-bot
Copy link
Contributor

che-bot commented Dec 15, 2023

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1024

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1024", name: che-dashboard}]}}]"

@akurinnoy akurinnoy requested a review from nickboldt December 15, 2023 13:45
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1dc6121) 87.96% compared to head (454e047) 87.99%.
Report is 2 commits behind head on main.

Files Patch % Lines
...dashboard-frontend/src/services/bootstrap/index.ts 44.44% 5 Missing ⚠️
...ontend/src/store/Workspaces/devWorkspaces/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   87.96%   87.99%   +0.03%     
==========================================
  Files         383      383              
  Lines       39316    39302      -14     
  Branches     2607     2606       -1     
==========================================
  Hits        34585    34585              
+ Misses       4706     4692      -14     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, nickboldt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit ce34226 into main Dec 18, 2023
12 of 13 checks passed
@akurinnoy akurinnoy deleted the upgrade-deps branch December 18, 2023 11:50
@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/427: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: dashboard_3.x/427: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5700 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2303: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5701: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5573 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2460: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5701 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1663: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5279: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2460 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1663: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2303: SUCCESS

3.12
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.12-25
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-639102-533291-s390x
  + quay.io/devspaces/iib:3.12-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.12-v4.13-639099-533286-s390x
  + quay.io/devspaces/iib:3.12-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.12-v4.12-639163-533281-s390x
  + quay.io/devspaces/iib:3.12-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.12-v4.11-639160-533277-s390x
  + quay.io/devspaces/iib:3.12-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-639102-533291-x86_64
  + quay.io/devspaces/iib:3.12-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-639099-533286-x86_64
  + quay.io/devspaces/iib:3.12-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-639163-533281-x86_64
  + quay.io/devspaces/iib:3.12-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-639160-533277-x86_64
  + quay.io/devspaces/iib:3.12-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.12-v4.14-639102-533291-ppc64le
  + quay.io/devspaces/iib:3.12-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-639099-533286-ppc64le
  + quay.io/devspaces/iib:3.12-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-639163-533281-ppc64le
  + quay.io/devspaces/iib:3.12-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-639160-533277-ppc64le
  + quay.io/devspaces/iib:3.12-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants