Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade lerna version #1124

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix: downgrade lerna version #1124

merged 2 commits into from
Jun 5, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 5, 2024

What does this PR do?

This PR fixed the 3.x downstream dashboard build failing for s390x and ppc64le.

What issues does this PR fix or reference?

https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DS_CI/job/get-sources-rhpkg-container-build_3.x/6852/consoleFull

@olexii4 olexii4 requested review from akurinnoy and ibuziuk as code owners June 5, 2024 12:32
@che-bot
Copy link
Contributor

che-bot commented Jun 5, 2024

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate lists of used dependencies.

Signed-off-by: Oleksii Orel <[email protected]>
Copy link

github-actions bot commented Jun 5, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1124

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1124", name: che-dashboard}]}}]"

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

New changes are detected. LGTM label has been removed.

Copy link

github-actions bot commented Jun 5, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1124

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1124", name: che-dashboard}]}}]"

@olexii4 olexii4 merged commit e6a16fa into main Jun 5, 2024
14 of 16 checks passed
@olexii4 olexii4 deleted the lerna_lib branch June 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants