-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
37193af
to
06cf487
Compare
Any Updates? |
Someone will review it by the end of the week. |
Any comments made from the che-plugin-registry PR should be made here too. @aditijadhav38 if that's the case, please update this PR. |
Yes working on incorporating the review comments given by Nick. |
c8027ed
to
f63fba2
Compare
I think I need to add the same changes I did on plugin registry there so it will include less changes |
@benoitf Could you please tell me by when you will be adding these changes, so accordingly we will update files |
I will work on it now 👍 |
Thank you so much for quick positive response. |
8abf06e
to
45dc9b5
Compare
@nickboldt @benoitf Just curious to check if we can use I tried using it to build |
I will let Florent address that one. I'm happy to use Fedora (bearing in mind we can't use it downstream), but UBI8 is better since that's what we'll be using in Brew to build CRW for OCP/Z. |
Well, if the rhel.Dockerfile is not used downstream either we remove it or we stick to ubi8. |
Signed-off-by: Aditi Jadhav <[email protected]>
45dc9b5
to
7f7d72d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much simpler solution. +1 from me.
@ericwill or @benoitf any concerns with this latest approach? Seems easy enough and won't be too painful to port to downstream (can't use Fedora but can use EPEL and unreleased RHEL bits). Also relatively confident this will work for ppc64le support instead of eclipse-che/che-plugin-registry#462 |
I'm fine (BTW AFAIK we don't use rhel.Dockerfile upstream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only thing of note is that Fedora 30 will be EOL in 6 months.
What does this PR do?
Add support for s390x