Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

S390x support #214

Merged
merged 1 commit into from
May 13, 2020
Merged

S390x support #214

merged 1 commit into from
May 13, 2020

Conversation

aditijadhav38
Copy link
Contributor

What does this PR do?

Add support for s390x

@aditijadhav38
Copy link
Contributor Author

Any Updates?

@ericwill
Copy link
Contributor

ericwill commented Apr 2, 2020

Someone will review it by the end of the week.

@ericwill
Copy link
Contributor

ericwill commented Apr 6, 2020

Any comments made from the che-plugin-registry PR should be made here too. @aditijadhav38 if that's the case, please update this PR.

@aditijadhav38
Copy link
Contributor Author

Any comments made from the che-plugin-registry PR should be made here too. @aditijadhav38 if that's the case, please update this PR.

Yes working on incorporating the review comments given by Nick.

@aditijadhav38 aditijadhav38 force-pushed the s390x-support branch 2 times, most recently from c8027ed to f63fba2 Compare April 17, 2020 12:35
@benoitf
Copy link
Contributor

benoitf commented Apr 17, 2020

I think I need to add the same changes I did on plugin registry there so it will include less changes

@aditijadhav38
Copy link
Contributor Author

@benoitf Could you please tell me by when you will be adding these changes, so accordingly we will update files

@benoitf
Copy link
Contributor

benoitf commented Apr 17, 2020

I will work on it now 👍

@aditijadhav38
Copy link
Contributor Author

I will work on it now 👍

Thank you so much for quick positive response.

@benoitf
Copy link
Contributor

benoitf commented Apr 17, 2020

#226

build.sh Outdated Show resolved Hide resolved
@aditijadhav38 aditijadhav38 force-pushed the s390x-support branch 2 times, most recently from 8abf06e to 45dc9b5 Compare April 23, 2020 12:36
@shahidhs-ibm
Copy link

@nickboldt @benoitf Just curious to check if we can use registry.fedoraproject.org/fedora-minimal docker image as base image in RHEL dockerfile. We are anyways using Fedora repositories so why not use its base image itself? The fedora-minimal image support multi-arch.

I tried using it to build che-plugin-registry docker image and I am able to do so on s390x arch. I can share the code changes if you want.

@nickboldt
Copy link
Contributor

I will let Florent address that one. I'm happy to use Fedora (bearing in mind we can't use it downstream), but UBI8 is better since that's what we'll be using in Brew to build CRW for OCP/Z.

@benoitf
Copy link
Contributor

benoitf commented Apr 28, 2020

Well, if the rhel.Dockerfile is not used downstream either we remove it or we stick to ubi8.

Signed-off-by: Aditi Jadhav <[email protected]>
@nickboldt nickboldt self-requested a review May 8, 2020 19:04
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler solution. +1 from me.

@nickboldt nickboldt requested a review from benoitf May 8, 2020 19:06
@nickboldt
Copy link
Contributor

@ericwill or @benoitf any concerns with this latest approach?

Seems easy enough and won't be too painful to port to downstream (can't use Fedora but can use EPEL and unreleased RHEL bits).

Also relatively confident this will work for ppc64le support instead of eclipse-che/che-plugin-registry#462

@benoitf
Copy link
Contributor

benoitf commented May 10, 2020

I'm fine (BTW AFAIK we don't use rhel.Dockerfile upstream)

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing of note is that Fedora 30 will be EOL in 6 months.

@nickboldt nickboldt merged commit ffea702 into eclipse-che:master May 13, 2020
@benoitf benoitf added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants