This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
chore(dog-fooding-extend): allow other repos that contain only devfiles folder to reuse the che-plugin-registry dogfooding scripts #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es folder to reuse the che-plugin-registry dogfooding scripts Signed-off-by: Sun Tan <[email protected]>
sunix
requested review from
benoitf,
ericwill,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
12 tasks
ericwill
approved these changes
Apr 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sun Tan [email protected]
What does this PR do?
Allow other devfile registries git repo to reuse the same dogfooding scripts to build and publish.
For instance CRW or this one https://github.com/sunix/devfiles
Screenshot/screencast of this PR
An example of dashboard using multiple devfile registries built with these scripts:
What issues does this PR fix or reference?
Not related, but used this to mockup eclipse-che/che#18473
Part of eclipse-che/che#19305
How to test this PR?
Could be tested with the default dogfooding devfile: make sure build works
Could also be tested with https://github.com/sunix/devfiles/blob/master/devfile.yaml but changing the upstream repo with this branch
I tested days ago with CRW but did not push the devfile :(
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.