Skip to content
This repository has been archived by the owner on Feb 2, 2022. It is now read-only.

Added existing dockerfiles used by che. #2

Merged
merged 4 commits into from
Aug 25, 2016
Merged

Added existing dockerfiles used by che. #2

merged 4 commits into from
Aug 25, 2016

Conversation

JamesDrummond
Copy link

  1. Copied everything from eclipse/che repo BUT /dockerfiles/Che-server folder. Removed the leading /dockerfiles folder after the move. Copied /dockerfiles/che-server/Dockerfile file to root directory.
  2. Copied the contents of the codenvy/dockerfiles repo to a directory called /recipes.

@JamesDrummond
Copy link
Author

@TylerJewell I removed che-server Dockerfile and add license + copy write header to files missing it.

@TylerJewell
Copy link
Contributor

I am a +1 for the merge once others give a thumbs up. This would then be our base repository for making dockerfile changes.

@TylerJewell
Copy link
Contributor

@benoitf @eivantsov @riuvshin - FYI - review this new repository. This preserves our ability to release images independently of Che releases. This takes out of the /che repo some important items that we need to release more frequently.

@JamesDrummond - we have two pull requests on the che repo that affect che-file and che-launcher. After those pull requests are merged into che repository, then we need to bring those files over here.

After we are confident that the CI systems can work with this new repository - we can then turn off CI for the other repositories and active it here, then removing the duplicate files from the other locations.

@benoitf
Copy link
Contributor

benoitf commented Aug 24, 2016

I would wait merge of eclipse-che/che#2119 and eclipse-che/che#2048 else this repository will be outdated

@TylerJewell
Copy link
Contributor

eclipse-che/che#2119 has been closed, so you can grab the updated files from /che/dockerfiles/che-launcher now.

@JamesDrummond
Copy link
Author

Updated che-launcher dockerfiles.

@benoitf
Copy link
Contributor

benoitf commented Aug 25, 2016

eclipse-che/che#2048 merged
and waiting for eclipse-che/che#2211
after that we're good

@TylerJewell
Copy link
Contributor

+1 - Jame's first pull request!

@TylerJewell TylerJewell merged commit d51de29 into eclipse-che:master Aug 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants