Skip to content
This repository has been archived by the owner on Mar 23, 2022. It is now read-only.

Update to use latest jdtls 0.30.0 milestone... #94

Closed
wants to merge 2 commits into from

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Dec 20, 2018

Update to use latest jdtls 0.30.0 milestone from 201812180348 so that we can fix this problem:

[ERROR] Failed to resolve target definition /home/hudson/.m2/repository/
org/eclipse/jdt/ls/org.eclipse.jdt.ls.tp/0.27.0.20181114223651/
org.eclipse.jdt.ls.tp-0.27.0.20181114223651.target: Failed to 
load p2 metadata repository from location 
http://download.eclipse.org/eclipse/updates/4.10-I-builds/: 
No repository found at http://download.eclipse.org/eclipse/updates/4.10-I-builds.

-- https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/CRW_CI/view/Pipelines/job/crw_master/57/console

Change-Id: I5ac9f37e19445f6ad8a4c6381ba435e3c4a91038
Signed-off-by: nickboldt [email protected]

Update to latest org.eclipse.jdt.ls.tp 0.30.0.20181220000357, which doesn't reference non-existant Eclipse 4.10 I build site

Change-Id: I5ac9f37e19445f6ad8a4c6381ba435e3c4a91038
Signed-off-by: nickboldt <[email protected]>
Change-Id: I292363f1db3c92ee61e2557e911c4f223543ad40
Signed-off-by: nickboldt <[email protected]>
@nickboldt
Copy link
Contributor Author

nickboldt commented Dec 20, 2018

Note that this fails locally for me with:

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:1.0.0:compile (default-compile) on project jdt.ls.extension.core: Compilation failure: Compilation failure: 
[ERROR] /home/nboldt/5-Che/0.github_upstream__mirror_to_code.eng_in_PNC/che-ls-jdt/org-eclipse-che-jdt-ls-extension/jdt.ls.extension.core/src/main/java/org/eclipse/che/jdt/ls/extension/core/internal/imports/OrganizeImportsCommand.java:[120] 
[ERROR] 	new CUCorrectionProposal("OrganizeImports", cu, IProposalRelevance.ORGANIZE_IMPORTS) {
[ERROR]             @Override
[ERROR]             protected void addEdits(IDocument document, TextEdit editRoot) throws CoreException {
[ERROR]               CompilationUnit astRoot = context.getASTRoot();
[ERROR]               OrganizeImportsOperation op =
[ERROR]                   new OrganizeImportsOperation(cu, astRoot, true, false, true, conflictResolver);
[ERROR]               editRoot.addChild(op.createTextEdit(null));
[ERROR]             }
[ERROR]           };
[ERROR] 	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ERROR] The constructor CUCorrectionProposal(String, ICompilationUnit, int) is undefined

So either we need to try an older jdtls (0.29? 0.28?) or we need to fix this compilation error to use the latest 0.30.

WDYT?

@tolusha
Copy link
Contributor

tolusha commented Dec 20, 2018

We have to fix compilation errors.

@nickboldt
Copy link
Contributor Author

Note that the same missing URL failure occurs with 0.29:

[ERROR] Failed to resolve target definition /home/nboldt/.m2/repository1/org/eclipse/jdt/ls/org.eclipse.jdt.ls.tp/0.29.0.20181203134803/org.eclipse.jdt.ls.tp-0.29.0.20181203134803.target: Failed to load p2 metadata repository from location http://download.eclipse.org/eclipse/updates/4.10-I-builds/: Unable to read repository at http://download.eclipse.org/eclipse/updates/4.10-I-builds. Artifact not found: http://download.eclipse.org/eclipse/updates/4.10-I-builds/I20181128-0130/content.xml.xz. -> [Help 1]

nickboldt added a commit to redhat-developer/devspaces that referenced this pull request Dec 20, 2018
Change-Id: Idaec8bc970f82c9a25ca3d97ab4fb25ecb37fa3c
Signed-off-by: nickboldt <[email protected]>
@svor
Copy link
Contributor

svor commented Dec 22, 2018

At first we need to solve this one eclipse-che/che#12262

@nickboldt
Copy link
Contributor Author

changes here merged in 44b81e1

@nickboldt nickboldt closed this Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants