chore: add memoryRequest for plugins sidecars

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Adds memory request in 20 megabytes for the plugin sidecars.

PR with pull-request check for memory and cpu limitations #1022

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#16685

How to test this PR?

A plugin registry with memory requests is temporary published to https://vgulyy-plugin-registry.surge.sh/v3/

1. create any workspace, install recommended plugins
2. stop the workspace, go to devfile on the dashboard
3. add registry URL to all the plugins to load them from temporary plugin registry

registryUrl: 'https://vgulyy-plugin-registry.surge.sh/v3'

4. start workspace, check how plugin works

Tested on:

• local minikube
• workspaces.openshift.com
• openshift 4.7 cluster on RHPDS

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[vitaliy-guliy]

/test all

[svor]

@vitaliy-guliy one question, I see che-machine-exec and remote-runtime-injector have memoryRequest: 32Mi, shouldn't we use the same value for sidecars or you think 20Mi is enough?

[vitaliy-guliy]

@vitaliy-guliy one question, I see che-machine-exec and remote-runtime-injector have memoryRequest: 32Mi, shouldn't we use the same value for sidecars or you think 20Mi is enough?

I have tested it with 20Mb and can say, that it works nicely.
memoryRequest is used when initializing the container (as I understand). A process, that running inside the container, can always ask for the required amount of memory when it's needed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svor, vitaliy-guliy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[svor]

/retest

[openshift-ci]

New changes are detected. LGTM label has been removed.

[codecov]

Codecov Report

Merging #1020 (bcd3bea) into main (47b9d43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files          44       44           
  Lines        1342     1342           
  Branches      197      197           
=======================================
  Hits         1263     1263           
  Misses         79       79           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b9d43...bcd3bea. Read the comment docs.