-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new version of Omnisharp plugin #199
Conversation
Signed-off-by: Valeriy Svydenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are licensing issues to be cleaned up in https://github.com/redhat-developer/omnisharp-theia-plugin/. Until we have those resolved, I'm blocking this PR.
Che 7.0.0 has been released. @svor what's the status of this PR? |
@l0rd It will be merged once eclipse-che/che#14224 is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on latest Che and found no significant issues.
- I still see Java LS "Classpath is incomplete" warning when loading petclinic che#13427 and need to refresh after restoring
- Completions on the sample project's
Program.cs
are kind of wonky, I can't get anything helpful there but it works forStartup.cs
.
@rhopp @l0rd @skabashnyuk we need to get the code owners approvals |
quick demo about how it works: https://youtu.be/Futqc4tNGLE |
@tsmaeder have licensing issues been tackled already? if this is the case please approve & merge the PR if it is planned for |
|
closing, the commit has been merged directly |
Signed-off-by: Valeriy Svydenko [email protected]
What does this PR do?
Provides new version of Theia Omnisharp plug-in and updates latest version.
This PR should fix a set of issues: eclipse-che/che#13892
Demo: https://youtu.be/Uc6ZS_8vS4w