Update Java extensions to latest #376
Conversation
tsmaeder
requested review from
benoitf,
nickboldt,
vinokurig and
vitaliy-guliy
as code owners
tsmaeder
force-pushed
the
15560_update_java
branch
from
e9dc40c to
9369bc7
Compare
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
There was a problem hiding this comment.
+1, but I might prefer to see 1.2.0-0.55.1 than 1.2.0a as the new version of quarkus-java8, as it's more meaningful / explains the re-release.
Historical context:
https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/vscode-camelk/0.0.10-4/meta.yaml vs https://github.com/eclipse/che-plugin-registry/blob/master/v3/plugins/redhat/vscode-camelk/0.0.10/meta.yaml
| extensions: | ||
| - https://download.jboss.org/jbosstools/vscode/3rdparty/vscode-java-debug/vscode-java-debug-0.24.0.vsix | ||
| - https://download.jboss.org/jbosstools/static/jdt.ls/stable/java-0.55.1-1984.vsix | ||
|
|
There was a problem hiding this comment.
Please add a trailing newline in case some of the build scripts expect it.
There was a problem hiding this comment.
Requiring an empty newline at the end of the file is so stupid it makes me want to scream. But yeah, fair point: I'll bow to the great machine
There was a problem hiding this comment.
https://i.redd.it/zibdmw9m66141.jpg You're not the only one annoyed by syntactic whitespace :)
Yeah, but that does not really scale, as we have multiple extensions in there. Using the VS Code extensions version as the Che plugin version only really works when you have a single extension. If what we have inside the Che plugin is relevant, we need a better way to show it. |
Signed-off-by: Thomas Mäder <[email protected]>
True dat. The flawed system is flawed. :( |
Update Java extensions to latest Signed-off-by: Thomas Mäder <[email protected]>
What does this PR do?
Updates Java related VS Code extensions to latest versions
Fix for: eclipse-che/che#15560