Buildkit Dev plugin

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Adds Buildkit Dev plugin to build docker images inside running container.

Solves issue eclipse-che/che#16539

Need also to change a pattern for the plugin logo image eclipse-che/che#16894

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[vitaliy-guliy]

It looks like we need to change the regexp for the plugin icon verification (remove it at all)
At the moment, it's impossible to use the URI like this https://avatars3.githubusercontent.com/u/27259197

Checking plugin 'moby/buildkit/0.7.1'
	u'mountPath' is a required property
	u'mountPath' is a required property
	u'https://avatars3.githubusercontent.com/u/27259197' does not match u'[-._a-zA-Z0-9]+?\\.(?:svg|png)(?:\\?.*)?$'

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[vitaliy-guliy]

[ci-test]

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[ericwill]

Tests are broken for now so they will always fail when triggered.

[vitaliy-guliy]

Should we remove the pattern for plugin images or it's better to update it?

    "icon": {
      "type": "string",
      "pattern": "[-_a-zA-Z0-9]+?(?:\\.(?:svg|png))?(?:\\?.*)?$"
    },

It looks like it works, but I'm not sure do we need it at all.

[ericwill]

Should we remove the pattern for plugin images or it's better to update it?

    "icon": {
      "type": "string",
      "pattern": "[-_a-zA-Z0-9]+?(?:\\.(?:svg|png))?(?:\\?.*)?$"
    },

It looks like it works, but I'm not sure do we need it at all.

We can discuss this change in the issue you filed for it, let's keep it for now in this PR.

[che-bot]

Happy path tests failed. Re-trigger by [ci-test] or [ci-test-happy-path]

[rhopp]

@vitaliy-guliy Tests should be fine now AFAIK... You just need to rebase on master.

[amisevsk]

I know regexes are generally write-only, but I'm having trouble understanding the change here. If .svg or .png is optional, it should be removed -- this regex reduces to

[-_a-zA-Z0-9](?:\\?.*)?$

[vitaliy-guliy]

You are right, we can omit checking for the extension here.

[che-bot]

Happy path tests passed.

[che-bot]

@vitaliy-guliy Happy Path PR check [build 56] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link	URL
console	https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/56/console
artifacts	http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/56/

Depending on failure reason, the artifacts or deployment may not be present.

[vitaliy-guliy]

[ci-test]

[che-bot]

Happy path tests passed.

[vitaliy-guliy]

[ci-test-happy-path]

[che-bot]

Happy path tests passed.