fix(java-plugin): Disable java semanticHighlighting by default #838
Conversation
Signed-off-by: Sun Tan <[email protected]>
sunix
requested review from
benoitf,
ericwill,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
| @@ -27,4 +27,9 @@ if [ "${USER_ID}" -ne 0 ] && command -v sudo >/dev/null 2>&1 && sudo -n true > / | |||
| sudo chown "${USER_ID}:${GROUP_ID}" /projects | |||
| fi | |||
|
|
|||
| echo 'Setting "java.semanticHighlighting.enabled" to false' | |||
There was a problem hiding this comment.
how does it work with multi-root workspaces ?
I think these kind of settings may be ignored
cc @RomanNikitenko
There was a problem hiding this comment.
How will multi-root workspaces deal with "workspace" settings? like the ones defined in the devfile?
There was a problem hiding this comment.
eclipse-che/che#17975 (comment) and the follow-up comment. Answer: we need some new code.
There was a problem hiding this comment.
But same is applying for the settings you apply in the devfile like: https://github.com/eclipse/che-devfile-registry/blob/dcfdacf3954e30a25a8af3c7bd497b193d24f14a/devfiles/quarkus/devfile.yaml#L59-L62
So the strategy needs to be covered in the multi-root PR
There was a problem hiding this comment.
I posted my thoughts about it here eclipse-che/che#17212 (comment)
Please share your opinion
|
What I can also do is disable edit: eclipse-che/che-theia#993. |
|
won't merge in favor of eclipse-che/che-theia#993 |
What does this PR do?
Quick fix for syntax highlighting. Semantic highlighting is not properly enriching the default syntax highlighting. Disabling it for now.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#18448
How to test this PR?
TODO
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.