Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode-commons vsix to all plugins #898

Closed
wants to merge 1 commit into from
Closed

Conversation

vinokurig
Copy link
Contributor

Signed-off-by: Igor Vinokur [email protected]

What does this PR do?

Create che-theia-default-extensions.yaml in the root of the plugin registry. This file contains a list of vsix files that should be present in all Che plugin registry entries.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#19361

How to test this PR?

The vscode-commons plugin must be present in the extensions list of all the plugins.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #898 (0bf79fc) into master (f1b8f37) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
+ Coverage   92.54%   92.60%   +0.06%     
==========================================
  Files          40       40              
  Lines        1060     1069       +9     
  Branches      133      134       +1     
==========================================
+ Hits          981      990       +9     
  Misses         79       79              
Impacted Files Coverage Δ
tools/build/src/build.ts 100.00% <100.00%> (ø)
...src/che-theia-plugin/che-theia-plugins-analyzer.ts 100.00% <100.00%> (ø)
...ols/build/src/devfile/meta-yaml-to-devfile-yaml.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a1e6e...0bf79fc. Read the comment docs.

@ericwill
Copy link
Contributor

@vinokurig you're ahead of schedule 😄

I think this work still needs discussion, for now can you just add the vscode-commons vsix to the following plugin entries:

  • vscode-java
  • Any of the plugins we have in the registry that are listed here

and we'll discuss the automatic adding in the issue.

@vinokurig vinokurig marked this pull request as draft March 24, 2021 13:40
@ericwill
Copy link
Contributor

ericwill commented Apr 8, 2021

I think we'll likely be making this extension a che-theia built-in, so I'm going to close this PR. Thanks for investigating!

@ericwill ericwill closed this Apr 8, 2021
@vinokurig vinokurig deleted the che-19361 branch January 12, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support telemetry for Red Hat VS Code extensions in Eclipse Che
2 participants