Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redhat.commons): Add VS Code commons extension #939

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Apr 28, 2021

What does this PR do?

Add VS Code commons extension

Screenshot/screencast of this PR

What issues does this PR fix or reference?

related to eclipse-che/che#19361

How to test this PR?

check extension is published in the registry (today no extension is using it directly in the current plugin registry)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Change-Id: I068a10c6f0b006948fcacd2fd92750a5ef586be7
Signed-off-by: Florent Benoit [email protected]

related to eclipse-che/che#19361

Change-Id: I068a10c6f0b006948fcacd2fd92750a5ef586be7
Signed-off-by: Florent Benoit <[email protected]>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benoitf, ericwill

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ericwill ericwill merged commit dedc3e9 into eclipse-che:master Apr 29, 2021
@che-bot che-bot added this to the 7.30 milestone Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants