Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest devfile versions support #637

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add latest devfile versions support #637

merged 2 commits into from
Jan 9, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jan 9, 2024

What does this PR do?

  • Add missing devfile versions to the list of supported devfile versions
  • Add corresponding jsons.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22753

How to test this PR?

  1. Deploy che from the PR image: quay.io/eclipse/che-server:pr-637
  2. Start a workspace from a repository with devfile version 2.2.2

See: workspace starts successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig vinokurig changed the title Add new devfile versions support Add latest devfile versions support Jan 9, 2024
@svor
Copy link
Contributor

svor commented Jan 9, 2024

should'n we remove devfile schema validation from che-server at all?
cc @ibuziuk @olexii4

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, but maybe we should consider removing devfile validation on the che-server end in the future releases. for 7.80.0 the fix with explicitly adding 2.2.2 works for me

Copy link

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jan 9, 2024
Copy link

openshift-ci bot commented Jan 9, 2024

New changes are detected. LGTM label has been removed.

§ithub.com:eclipse-che/che-server into che-22753
@vinokurig vinokurig merged commit d077bdd into main Jan 9, 2024
27 checks passed
@vinokurig vinokurig deleted the che-22753 branch January 9, 2024 16:16
@vinokurig
Copy link
Contributor Author

Merged as discussed in the retrospective call.

@devstudio-release
Copy link

Build 3.12 :: server_3.x/306: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: server_3.x/306: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5872 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.12 :: sync-to-downstream_3.x/5873: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5740 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.12 :: operator-bundle_3.x/2523: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5873 triggered

@devstudio-release
Copy link

Build 3.12 :: copyIIBsToQuay/2376: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1720: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.12 :: update-digests_3.x/5496: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/2523 triggered

@devstudio-release
Copy link

Build 3.12 :: dsc_3.x/1720: SUCCESS

3.12.0-CI

@devstudio-release
Copy link

Build 3.11 :: server_3.11/2: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: server_3.11/2: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.11/62 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.11/228: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start a workspace via factory with devfile 2.2.2
4 participants