-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest devfile versions support #637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, but maybe we should consider removing devfile validation on the che-server end in the future releases. for 7.80.0 the fix with explicitly adding 2.2.2 works for me
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
§ithub.com:eclipse-che/che-server into che-22753
Merged as discussed in the retrospective call. |
Build 3.12 :: server_3.x/306: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5872: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4112: Console, Changes, Git Data |
Build 3.12 :: get-sources-rhpkg-container-build_3.x/5739: server : 3.x :: Build 57942314 : quay.io/devspaces/server-rhel8:3.12-15 |
Build 3.12 :: update-digests_3.x/5496: Console, Changes, Git Data |
Build 3.12 :: server_3.x/306: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5872 triggered |
Build 3.12 :: operator-bundle_3.x/2523: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5873: Console, Changes, Git Data |
Build 3.12 :: push-latest-container-to-quay_3.x/4113: Console, Changes, Git Data |
Build 3.12 :: sync-to-downstream_3.x/5873: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5740 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.12 :: operator-bundle_3.x/2523: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5873 triggered |
Build 3.12 :: copyIIBsToQuay/2376: Console, Changes, Git Data |
Build 3.12 :: dsc_3.x/1720: Console, Changes, Git Data |
Build 3.12 :: update-digests_3.x/5496: Detected new images: rebuild operator-bundle |
Build 3.12 :: dsc_3.x/1720: 3.12.0-CI |
Build 3.11 :: server_3.11/2: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.11/62: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.11/55: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.11/61: server : 3.11 :: Build 57948783 : quay.io/devspaces/server-rhel8:3.11-24 |
Build 3.11 :: server_3.11/2: Upstream sync done; /DS_CI/sync-to-downstream_3.11/62 triggered |
Build 3.11 :: update-digests_3.11/228: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.11/228: No new images detected: nothing to do! |
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#22753
How to test this PR?
quay.io/eclipse/che-server:pr-637
2.2.2
See: workspace starts successfully.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.