Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add redhat vscode-commons extension to the default plugins list #1082

Closed
wants to merge 1 commit into from

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Add redhat vscode-commons extension to the default plugins list

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19361

How to test this PR?

The vscode-commons plugin must be present in the list of installed plugins

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't think it's the way to go

Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is pending until tomorrow's cabal discussion

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1082 (6506134) into master (eeb4526) will increase coverage by 1.82%.
The diff coverage is 49.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   29.45%   31.27%   +1.82%     
==========================================
  Files         277      277              
  Lines        9336     9393      +57     
  Branches     1380     1403      +23     
==========================================
+ Hits         2750     2938     +188     
+ Misses       6487     6358     -129     
+ Partials       99       97       -2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts 0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts 0.00% <0.00%> (ø)
...a-plugin-remote/src/node/webviews-content-aware.ts 0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts 0.00% <ø> (ø)
...e-theia-remote-api/src/common/workspace-service.ts 0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts 0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6077388...6506134. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Apr 20, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1082
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1082

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@ericwill
Copy link
Contributor

After further discussion it's been decided to add an entry to the plugin registry, and then enable it as a default plugin in che-server: https://github.com/eclipse/che/blob/master/assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties#L726

@ericwill ericwill closed this Apr 26, 2021
@vinokurig vinokurig deleted the che-19361 branch June 10, 2021 11:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants